Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use local glob types #339

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: use local glob types #339

merged 1 commit into from
Oct 30, 2024

Conversation

erikian
Copy link
Member

@erikian erikian commented Oct 30, 2024

Follow-up to #336, as pointed out in #336 (comment) I forgot to actually replace the usages of the IOptions type from glob by our local copy.

Fixes #330.

@erikian erikian requested a review from a team as a code owner October 30, 2024 12:03
@erikian erikian mentioned this pull request Oct 30, 2024
@erikian erikian merged commit e313c0a into main Oct 30, 2024
4 checks passed
@erikian erikian deleted the fix/use-local-glob-types branch October 30, 2024 14:31
Copy link

🎉 This PR is included in version 3.2.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

@t3chguy
Copy link

t3chguy commented Oct 30, 2024

Thanks @erikian - can confirm this works: element-hq/element-desktop#1966

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Please remove dependency on @types/glob which is not required and causes breakage in typedoc builds
4 participants