Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: session.clearData avoidClosingConnections default to false #45187

Merged
merged 1 commit into from
Jan 15, 2025
Merged

fix: session.clearData avoidClosingConnections default to false #45187

merged 1 commit into from
Jan 15, 2025

Conversation

clavin
Copy link
Member

@clavin clavin commented Jan 13, 2025 •
edited
Loading

Description of Change

Fixes #44853.

The clearData API uses kClearDataTypeAll when the dataTypes option is not set. This default value currently includes the avoidClosingConnections option, which contradicts that option's default value of false. This PR updates the default value (kClearDataTypeAll) to respect avoidClosingConnections's default value of false.

Checklist

Release Notes

Notes: The avoidClosingConnections option for session.clearData now properly defaults to false when the dataTypes option is not set.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened in the last 24 hours label Jan 13, 2025
@clavin clavin added target/33-x-y PR should also be added to the "33-x-y" branch. target/34-x-y PR should also be added to the "34-x-y" branch. labels Jan 13, 2025
felixrieseberg
felixrieseberg approved these changes Jan 13, 2025
View reviewed changes
Copy link
Member

@felixrieseberg felixrieseberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So simple, so good!

@codebytere codebytere added the semver/patch backwards-compatible bug fixes label Jan 15, 2025
@electron-cation electron-cation bot added new-pr 🌱 PR opened in the last 24 hours and removed new-pr 🌱 PR opened in the last 24 hours labels Jan 15, 2025
@jkleinsc jkleinsc merged commit 6f7999a into main Jan 15, 2025
68 checks passed
@jkleinsc jkleinsc deleted the clavin/avoid-closing-connections-default-false branch January 15, 2025 16:38
@release-clerk Release Clerk
Copy link

release-clerk bot commented Jan 15, 2025

Release Notes Persisted

The avoidClosingConnections option for session.clearData now properly defaults to false when the dataTypes option is not set.

This was referenced Jan 15, 2025
Merged
Merged
@trop
Copy link
Contributor

trop bot commented Jan 15, 2025

I have automatically backported this PR to "33-x-y", please check out #45207

@trop trop bot added in-flight/33-x-y and removed target/33-x-y PR should also be added to the "33-x-y" branch. labels Jan 15, 2025
@trop
Copy link
Contributor

trop bot commented Jan 15, 2025

I have automatically backported this PR to "34-x-y", please check out #45208

@trop trop bot added in-flight/34-x-y merged/34-x-y PR was merged to the "34-x-y" branch. merged/33-x-y PR was merged to the "33-x-y" branch. and removed target/34-x-y PR should also be added to the "34-x-y" branch. in-flight/34-x-y in-flight/33-x-y labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VerteDinde VerteDinde VerteDinde approved these changes

@codebytere codebytere codebytere approved these changes

@felixrieseberg felixrieseberg felixrieseberg approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
merged/33-x-y PR was merged to the "33-x-y" branch. merged/34-x-y PR was merged to the "34-x-y" branch. semver/patch backwards-compatible bug fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

avoidClosingConnections option on session.clearData() doesn't work without dataTypes
5 participants
@clavin @jkleinsc @felixrieseberg @codebytere @VerteDinde