cleanup types more

electron · Nov 16, 2024 · ecdb212 · ecdb212
1 parent 7814699
commit ecdb212
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/packages/maker/dmg/src/Config.ts b/packages/maker/dmg/src/Config.ts
@@ -35,4 +35,4 @@ export interface AdditionalDMGOptions {
   'code-sign'?: CodeSignOptions;
 }
 
-export type MakerDMGConfig = Omit<ElectronInstallerDMGOptions, 'name' | 'appPath'> & { name?: string };
+export type MakerDMGConfig = Omit<ElectronInstallerDMGOptions, 'name' | 'appPath' | 'out'> & { name?: string };
diff --git a/packages/maker/dmg/src/MakerDMG.ts b/packages/maker/dmg/src/MakerDMG.ts
@@ -6,6 +6,8 @@ import fs from 'fs-extra';
 
 import { MakerDMGConfig } from './Config';
 
+import type { ElectronInstallerDMGOptions } from 'electron-installer-dmg';
+
 export default class MakerDMG extends MakerBase<MakerDMGConfig> {
   name = 'dmg';
 
@@ -22,7 +24,7 @@ export default class MakerDMG extends MakerBase<MakerDMGConfig> {
     const forgeDefaultOutPath = path.resolve(makeDir, `${appName}-${packageJSON.version}-${targetArch}.dmg`);
 
     await this.ensureFile(outPath);
-    const dmgConfig = {
+    const dmgConfig: ElectronInstallerDMGOptions = {
       overwrite: true,
       name: appName,
       ...this.config,