fix(template-vite): incorrectly bundling browser entrypoints #3278
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summarize your changes:
In some cases
browserField: false
in thevite.main.config.js
is not sufficient to ensure that the Node version of a package is bundled (or rather, the browser version is not bundled) - in particular where the package uses conditional exports, because Vite's resolver favours conditions over the browser field:This PR ensures that we set the
node
condition, which also makes Vite not load the browser version in certain cases.I've tested this locally using the
ws
package: before this change it would throw an error when used from the main process (because it has a browser entrypoint that throws), while it doesn't with this change applied to my config.