fix: win32 asset matching pattern #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Setch <[email protected]>
Signed-off-by: Adam Setch <[email protected]>
erickzhao
changed the title
|
Awesome, thanks @erickzhao 🙇 |
setchy
changed the title
erickzhao
changed the title
adityaraute
reviewed
Dec 9, 2024
There was a problem hiding this comment.
What's the logic for this change?
Why not use an if-else ladder instead?
|
@erikian could you kindly assist with this PR, too 🙏 |
erikian
approved these changes
Jan 3, 2025
|
@setchy looks good - can you rebase this PR? |
…t-matching Signed-off-by: Adam Setch <[email protected]>
|
merge conflict resolved @erikian 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
per @erickzhao feedback here #169 (review), change windows asset matching for consistency with #169 changes