Android: force em values to use the X.em format

[jmartinesp]

There might be a better way to do this, but I couldn't find it.

The issue

src/transforms/kotlin/percentageEm.ts transforms % values into em ones with the format X.em (note the dot is important for Kotlin).

However, when this value is later used in src/transforms/kotlin/typography.ts, it seems like it's re-interpreted by the style dictionary in some way and it returns Xem instead for round values (without the dot). If I return something that can't re reinterpreted (such as 0.em!) it'll be provided as is in typography.ts, without any changes.

The workaround

Always return a value with a decimal place, even if it's .0 for round values. This way the .em is kept, probably because the returned value is not re-interpreted as an em one by style dictionary.

[pixlwave]

FWIW, looks reasonable to me, but maybe you want to wait for Robin as I have no idea about what might be a better solution :)

[robintown]

I'm taking a quick look, I'll let you know if I see something better

[robintown]

This fixes it:

diff --git a/src/configs/getAndroidConfig.ts b/src/configs/getAndroidConfig.ts
index 25e57d0..bfd1db7 100644
--- a/src/configs/getAndroidConfig.ts
+++ b/src/configs/getAndroidConfig.ts
@@ -240,7 +240,6 @@ export function getCommonAndroidConfig(): PlatformConfig {
   return {
     transforms: [
       "camelCaseDecimal",
-      "ts/resolveMath",
       "attribute/cti",
       "kotlin/fontWeight",
       "kotlin/literal",

The reason seems to be that Tokens Studio transforms (which is where ts/resolveMath comes from) started out as a Web-oriented project and is not yet aware of how to format dimensional values for iOS and Android. We're actually early adopters!

In theory we should resolve math expressions even for Android, but in practice we're not using them yet, so this should work for now. If we ever do need them, we could contribute support for Kotlin-style dimensions to the Tokens Studio project.

[jmartinesp]

Yes, I can confirm it works by just removing it. Thanks @robintown !