Update react monorepo to v19 (major) #290
Conversation
![renovate[bot]](https://avatars.githubusercontent.com/in/2740?s=60&v=4){kind=small}
Deploying compound-web with
|
| Latest commit: |
0ea89f6
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://ebe27070.compound-web.pages.dev |
| Branch Preview URL: | https://renovate-major-react-monorep.compound-web.pages.dev |
renovate
bot
requested review from
dbkr and
robintown
and removed request for
a team
renovate
bot
force-pushed
the
renovate/major-react-monorepo
branch
from
41265a2 to
d302631
Compare
renovate
bot
force-pushed
the
renovate/major-react-monorepo
branch
from
acef524 to
c058910
Compare
|
@sandhose Looks like Renovate force-pushed and overwrote your changes (which is odd, that's not supposed to happen) |
|
This is intentional on my side, I wanted to rebase on top of #294. I still have to backport the fixes I did |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
| @@ -106,11 +106,10 @@ function ReleaseAnnouncementAnchor({ | |||
| children, | |||
| context.getReferenceProps({ | |||
| ref, | |||
| ...children.props, | |||
There was a problem hiding this comment.
cloneElement will anyway keep the existing props
| // If the ReleaseAnnouncement is open, we need manually aria-describedby. | ||
| // The RA has the dialog role and it's not adding automatically the aria-describedby. | ||
| ...(context.open && { | ||
| "aria-describedby": context.getFloatingProps().id, | ||
| "aria-describedby": context.getFloatingProps().id as string, |
There was a problem hiding this comment.
getFloatingProps returns Record<string, unknown>, but we know this is a string
|
|
||
| // Unfortunately Omit doesn't distribute nicely over sum types, so we have to | ||
| // piece together the useTooltip options type by hand | ||
| type TooltipProps = Omit<CommonUseTooltipProps, "isTriggerInteractive"> & | ||
| XOR<TooltipLabel, TooltipDescription> & { | ||
| (TooltipLabel | TooltipDescription) & { |
There was a problem hiding this comment.
ts-xor really makes it impossible to use in some context, especially stories, so I removed it
src/utils/SuspenseImg.tsx
Outdated
|
@robintown I've opened #297 to fix that, I'll rebase on top of it once merged |
This was missing a TooltipProvider
This PR contains the following updates:
^18.2.21->^19.0.0^18->^18 || ^19.0.0^18.2.0->^19.0.0^18.3.1->^19.0.0Release Notes
facebook/react (react)
v19.0.0Compare Source
facebook/react (react-dom)
v19.0.0Compare Source
Configuration
📅 Schedule: Branch creation - "* 0-3 * * 1" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.