-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Url preview endpoint #3444
base: main
Are you sure you want to change the base?
Url preview endpoint #3444
Conversation
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Signed-off-by: Aleksandr Dubovikov <[email protected]>
Signed-off-by: adnull <[email protected]>
Quick notes: Also, I'd prefer |
Signed-off-by: adnull <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3444 +/- ##
==========================================
+ Coverage 49.40% 49.71% +0.30%
==========================================
Files 524 526 +2
Lines 59814 60434 +620
==========================================
+ Hits 29554 30042 +488
- Misses 26776 26856 +80
- Partials 3484 3536 +52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: adnull <[email protected]>
Signed-off-by: adnull <[email protected]>
Implemented allow/deny lists checking from federation config. Maybe to move these lists to make them global? |
Signed-off-by: adnull <[email protected]>
This PR introduces the missing URL Preview functionality ( Issue matrix-org/dendrite#1303 )
According to the specification that endpoint requests require authentication and are rate limited. There are both endpoints (v1 and v3) as some clients still use deprecated endpoints for url preview requests.
Key features:
Missing:
I'd like somebody to take a look at the code.
Signed-off-by:
adnull <[email protected]>