Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve back-navigation for invitations #2024

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Improve back-navigation for invitations #2024

merged 1 commit into from
Dec 14, 2023

Conversation

ganfra
Copy link
Member

@ganfra ganfra commented Dec 14, 2023

Always close the invite list screen when there is no more invite : closes #2022

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link
Contributor

📱 Scan the QR code below to install the build (arm64 only) for this PR.
QR code
If you can't scan the QR code you can install the build via this link: https://i.diawi.com/HcLG1S

@codecov Codecov
Copy link

codecov bot commented Dec 14, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (09483ee) 67.72% compared to head (cbd5b24) 67.72%.
Report is 22 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop    #2024   +/-   ##
========================================
  Coverage    67.72%   67.72%           
========================================
  Files         1327     1327           
  Lines        33607    33607           
  Branches      7249     7249           
========================================
  Hits         22761    22761           
  Misses        7413     7413           
  Partials      3433     3433

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ganfra ganfra marked this pull request as ready for review December 14, 2023 11:58
@ganfra ganfra requested a review from a team as a code owner December 14, 2023 11:58
@ganfra ganfra requested review from bmarty and removed request for a team December 14, 2023 11:58
bmarty
bmarty approved these changes Dec 14, 2023
View reviewed changes
Copy link
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice solution, thanks!

appnav/src/main/kotlin/io/element/android/appnav/LoggedInFlowNode.kt
matrixClient.roomListService.invites.loadingState
.collect { inviteState ->
when (inviteState) {
is RoomList.LoadingState.Loaded -> if (inviteState.numberOfRooms == 0) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question: any idea why it's called maximumNumberOfRooms Rust side?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd say because it doesn't reflect the actual number of rooms we got from SlidingSync ? but not sure

@ganfra ganfra added the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 14, 2023
@ganfra ganfra enabled auto-merge December 14, 2023 14:02
@github-actions github-actions bot removed the Run-Maestro Starts a Maestro Cloud session to run integration tests label Dec 14, 2023
@ganfra ganfra disabled auto-merge December 14, 2023 14:24
@ganfra ganfra merged commit a5a7f5a into develop Dec 14, 2023
16 of 18 checks passed
@ganfra ganfra deleted the feature/fga/invite_list_back_navigation branch December 14, 2023 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmarty bmarty bmarty approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Always close the invite list screen when there is no more invite
2 participants
@ganfra @bmarty