-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UI to record a voice message from the composer toolbar #1892
Conversation
Generated by 🚫 Danger Swift against 36e3fdd |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1892 +/- ##
===========================================
- Coverage 70.91% 70.28% -0.63%
===========================================
Files 464 473 +9
Lines 31468 32228 +760
Branches 15355 15705 +350
===========================================
+ Hits 22316 22653 +337
- Misses 8588 8992 +404
- Partials 564 583 +19
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! 👏 Left a couple of comments inline but nothing major.
ElementX/Sources/Screens/ComposerToolbar/View/VoiceMessageRecordButtonTooltipView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/ComposerToolbar/View/VoiceMessageRecorderComposer.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/ComposerToolbar/View/VoiceMessageRecorderComposer.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/ComposerToolbar/View/VoiceMessageRecordingView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/ComposerToolbar/View/VoiceMessageRecordingView.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/ComposerToolbar/View/VoiceMessageRecordButton.swift
Outdated
Show resolved
Hide resolved
ElementX/Sources/Screens/ComposerToolbar/View/VoiceMessageRecordButton.swift
Outdated
Show resolved
Hide resolved
98abb34
to
5dddc22
Compare
5dddc22
to
36e3fdd
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
@nimau I'm missing how to "lock" the recording without the need to keep the recording button pressed all the time. Will it be the "slide up" gesture like in the current Element/IOS? |
@jacotec, for this first implementation of voice message recording, it is not currently possible to "lock" the recording. |
@nimau Hopefully this will be added? It' pretty useless in the car then, much too dangerous to keep the finger all the time on the phone in the holder. Same for longer messages ... |
This PR adds the user interface for recording a voice message from the composer toolbar (first part of the story Record and send a voice message)
The recording itself is not yet implemented (but an audio recorder has already been added).
If the feature flag is set, these are the new states of the composer toolbar:
A tooltip is displayed:
The composer displays the recording view:
The composer displays the voice message preview with the send button: