IconGroupContainer/force_reposition: Fix crash (use after free)

elementary · Jul 28, 2024 · 72ee7e1 · 72ee7e1
1 parent 66679ca
commit 72ee7e1
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/src/Widgets/IconGroupContainer.vala b/src/Widgets/IconGroupContainer.vala
@@ -153,13 +153,15 @@ namespace Gala {
 
             foreach (var child in children) {
                 if (child is IconGroup) {
+                    child.ref (); //The list only contains weak references so make sure the child isn't freed before it's added again
                     remove_group ((IconGroup) child);
                 }
             }
 
             foreach (var child in children) {
                 if (child is IconGroup) {
                     add_group ((IconGroup) child);
+                    child.unref ();
                 }
             }
         }