Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't block Alt + Shift when there is only one keyboard layout #1756

Merged
merged 7 commits into from
Sep 29, 2023
Merged

Don't block Alt + Shift when there is only one keyboard layout #1756

merged 7 commits into from
Sep 29, 2023

Conversation

lenemter
Copy link
Member

Fixes #1261

@lenemter lenemter requested a review from a team September 13, 2023 06:49
@tintou
Copy link
Member

tintou commented Sep 29, 2023

The thing is, how does it react when you assign the shortcut to something else then add a keyboard layout?

@lenemter
Copy link
Member Author

lenemter commented Sep 29, 2023 •
edited
Loading

@tintou Alt + Shift will trigger layout switch and if a shortcut with these accelerators was set, it will be broken. This branch just blocks layout switch shortcut if there is only one keyboard layout in order to avoid the issue on such systems.

@tintou tintou merged commit 844eb95 into master Sep 29, 2023
4 checks passed
@tintou tintou deleted the dont-block-alt-shift branch September 29, 2023 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tintou tintou tintou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Alt + Shift unnecessarily blocked when there is only one keyboard layout.
2 participants
@lenemter @tintou