Use clutter for the background menu #1769
Conversation
leolost2605
changed the title
|
Seems like the menus don't get properly destroyed and still take input after being closed. 2023-10-02.00-21-58.mp4Second, they can go off screen when clicked close to the screen edge.
Third, seems like there is no black outline in dark mode unlike other menus. I briefly looked into the stylesheet code and couldn't find why it's broken. And the last, the menu is shorter for some reason. Menus' min-width is clearly 150px in stylesheet, but in reality it's 205? |
|
I’m a little concerned about like needing to create and maintain half a toolkit here to support everything that Gtk does with a11y and localization etc. maybe @tintou has thoughts/suggestions. I wonder if it would be better to just have a full screen transparent window so that it could position its own popover? |
|
Yes I think that the background menu is an exact usecase of Meta.WaylandClient as it is tightly tied to Gala |
|
@danirabbit @tintou Gala still needs a Gala.Menu for window menus. So why don't just use Gala.Menu for everything? And talking about gala's toolkit, it has many a11y issues e.g. #1301, but that doesn't mean we need to replace say window switcher with Gtk implementation. We should put more effort into developing gala instead of searching hacky solutions with Gtk. |
|
As @lenemter said the window menu was my primary concern too. I think we would have to go very hacky to get that working with only GTK...? |
|
|
||
| menuitem.leave_event.connect (() => { | ||
| selected = null; | ||
| return false; |
There was a problem hiding this comment.
| return false; | |
| return Clutter.EVENT_PROPAGATE; |
|
|
||
| menuitem.enter_event.connect (() => { | ||
| selected = menuitem; | ||
| return false; |
There was a problem hiding this comment.
| return false; | |
| return Clutter.EVENT_PROPAGATE; |
|
See #1844 |
The current way of handling window and desktop menus doesn't work under wayland because the daemon can't position the menus and AFAIK they don't work properly without a parent (see @Marukesu's comment here)
With this PR we add a
Gala.MenuClutter Actor that is then used to create the background menu. In a follow up the same can be used (with some additional effort) for the window menu.The appearing and disappearing of the menu is currently slightly animated not sure if we want to keep that (I just took it from the WindowSwitcher).
The original Gtk.Menu's add some additional space to the end of the menu items. When porting to GTK4 we don't do that when replacing Menus with popovers, and popovermenus don't do it by themselves so I didn't do it here.
Fixes #1695 and sets the foundation for a follow up to f*x #1696