Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't create window snapshots if animations are disabled #1778

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Don't create window snapshots if animations are disabled #1778

merged 1 commit into from
Oct 25, 2023

Conversation

lenemter
Copy link
Member

No description provided.

@lenemter lenemter requested a review from a team October 25, 2023 02:13
danirabbit
danirabbit approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm that this variable is only used in functions that already return early if animations are disabled, so this makes sense. Nice little optimization!

@danirabbit danirabbit merged commit 91d70aa into master Oct 25, 2023
4 checks passed
@danirabbit danirabbit deleted the avoid-creating-snapshots branch October 25, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lenemter @danirabbit