Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove expose-windows shortcut #1795

Merged
merged 4 commits into from
Nov 9, 2023

Conversation

lenemter
Copy link
Member

@lenemter lenemter commented Oct 30, 2023

The first step towards #485
Removes window spread for one workspace. AFAIK it does the exact same thing as the multitasking view, so it can be removed.

Do not merge until #1777

@lenemter lenemter requested a review from a team October 30, 2023 16:44
<value nick="switch-to-workspace-previous" value="8" />
<value nick="switch-to-workspace-next" value="9" />
<value nick="switch-to-workspace-last" value="10" />
<value nick="window-overview-all" value="6" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if changing the value here will mess up system settings? It seems odd that the value is a number here tbh. But might need to preserve the numbers for now even though there would be a missing option just to not break things

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this enum is used only in hotcorners key, and settings plug set the value using string and not actual enum value. So it shouldn't break anything.

data/gala.gschema.xml Show resolved Hide resolved
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go 🚀

@danirabbit danirabbit enabled auto-merge (squash) November 9, 2023 21:47
@danirabbit danirabbit merged commit f5391ae into master Nov 9, 2023
4 checks passed
@danirabbit danirabbit deleted the lenemter/start-removing-window-overview branch November 9, 2023 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants