Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkspaceManager: Exclude a window that's about to be removed from count #2160

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

leolost2605
Copy link
Member

@leolost2605 leolost2605 commented Dec 11, 2024

Fixes #2145

Though probably not the same as #2145 (I've seen this one before the gesturepropertytransition got merged and the system version says stable) this probably also fixes #2159

We have to do this because a window that's about to be removed still appears in the list returned by Meta.Workspace.list_windows when window_removed is emitted (at least if it's just moved and not closed).

Also fixes an inconsistency, where when in the multitasking view, a workspace would be immediately removed when the last window on it was closed but not when it was moved to another one.

@leolost2605 leolost2605 requested a review from a team December 11, 2024 20:14
@lenemter
Copy link
Member

lenemter commented Dec 18, 2024

Looked into mutter code and indeed it's the cause of the issue. _MetaWorkspace stores the windows but when list_windows () is called it fetches windows from the Meta.Display and filters them, so when window_removed is called workspace has removed the window from internal list, but not from the display's list. Should we report this upstream? Or maybe @tintou knows if this is intentional behaviour?

@lenemter lenemter merged commit 8069298 into main Dec 18, 2024
5 checks passed
@lenemter lenemter deleted the leolost/fix-ws-switch-crash branch December 18, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash after #2074 Crash when moving windows between workspaces and using gestures to switch
2 participants