-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Toasts: Overlay close button on corner #480
Conversation
Noice, I think it goes far better with the elementary style, and doesn't take up needless space on something that self-dismisses anyway. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might want to bump copyright while you're at it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not tested yet but leaving some nitpicking coding style review.
Co-authored-by: Ryo Nakano <[email protected]>
Co-authored-by: Ryo Nakano <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR does not seem to do the styling of the close button? When I tried it the close button was not in the required style so not really usable. Other than that this, the code LGTM and works as expected.
Should this be blocked pending amendments to the stylesheet being merged?
@alainm23 Any chance you could try fix the problem so it can be merged? |
I have another idea in mind for Granite.Toast, I'll close this for now. |
Fixes #378.