WIP: Actions: Make edit-clear more consistent #1146
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@danirabbit , you mentioned in the issue
I wasn't totally sure what enabling the fallbacks meant or where exactly to look. I checked for symlinks and the like and didn't find any that needed changing, but wasn't sure what more to do (edit: see followup reply). The rest I think should be on the right track. Moved
edit-clear
Broom icons toedit-clear-all
, makeedit-clear
all use the red Backspace symbol. I did add theerror
class to the symbolicedit-clear
icons to make them red if that is okay.One thing I'm not sure on is the sizes. I did a new
edit-clear
based on themail-mark-important
icon (as mentioned in the issue) at 16px. Should this be done at other sizes? I'm not sure that these icons are used beyond the text-entry boxes (16px) or possibly toolbar icons (24px), so I'm not sure that 32x, 48px, etc are needed (and if not should the largeredit-clear-all
icons be removed as well?).Current:
Proposed:
Also played with making the new regular
edit-clear
a few pixels longer vs a little more square (edit-clear0), wasn't sure which to go with but I like the longer one a little more, it's a bit more legible:Git Log:
edit-clear
: red backspace symboledit-clear-symbolic
: red backspace symbol, error class addededit-clear-all
andedit-clear-all-symbolic
: broom symbolFixes #1126