PartitionBar: make sure we get click events

[danirabbit]

Fixes #763
Closes #767

I can't actually get the menu to popup in this branch or any previous commit since the last release, but this makes sure the gesture sends the event at least. Maybe the menu only works in an actual installer session for some reason?

[vjr]

@danirabbit

When I click I see a message like "gtk popover - assertion failed - GTK_IS_POPOVER is not a popover"...

I had tried to fix this issue - I also changed Box to EventBox and also re-added the button pressed mask. I had to move the gesture.connect (menu.popup) from the construct block up to the constructor, because apparently the block was being executed before the constructor where the menu was actually being created - this fixed the debug message about "GTK_IS_POPOVER not being a popover".

I also re-added the local/private method that called menu.popup () with a log statement that confirmed the click event is happening but menu.popup () does nothing.

Is there some sort of GTK setup required - like adding the widgets in a hierarchy so that the event from the eventbox (partitionbar) is propagated down to the partitionmenu widget?

hope what ive written here is not too much gibberish :-)

[danirabbit]

@vjr okay so this has multiple layers haha.

One layer is this: which means even when the menu does popup it's closed immediately #767

[vjr]

@danirabbit so how do i test? do i need to apply both PRs or just #767 ?

[danirabbit]

@vjr okay actually, it was simpler than I thought and it's now fixed in this branch. This can be rebase merged :)

[vjr]

LGTM - the popup is working now - please merge so the upcoming daily iso builds get this fix - i intend to install and further test os8 - thanks!