Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diskbar: responsive redesign #770

Merged
merged 7 commits into from
May 15, 2024
Merged

Diskbar: responsive redesign #770

merged 7 commits into from
May 15, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented May 14, 2024 •
edited
Loading

Fixes #691

Screenshot from 2024-05-14 13 04 43
Screenshot from 2024-05-14 13 08 16

Also Gtk4 prep:

  • Set size of elements in CSS
  • Lay out vertically
  • Use Granite.HeaderLabel
  • Replace grids with boxes
  • Code style
  • Make legend item clickable anywhere on the item
  • Don't use Granite style class that doens't exist in GTK 4

@danirabbit danirabbit requested a review from a team May 14, 2024 20:12
@danirabbit danirabbit merged commit 3f8dcc1 into master May 15, 2024
3 of 5 checks passed
@danirabbit danirabbit deleted the danirabbit/diskbar-gtk4prep branch May 15, 2024 03:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zeebok zeebok zeebok approved these changes

Assignees
No one assigned
Labels
None yet
Projects
GTK4 Porting
Status: Done
Responsive Design
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Partitions legend seems clipped (is actually scrollable)
2 participants
@danirabbit @zeebok