Terminal: gtk4prep #780
Merged
Terminal: gtk4prep #780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
danirabbit
commented
May 28, 2024
•
danirabbit
commented
- Can't subclass scrolledwindow
- Code style
- Can't connect to size_allocate anymore, so just try to scroll on idle
- Add log output to test mode so we can test it
Merged
|
I am not sure if it is because of the code changes or something else but when I get to the progress view, I see the "I'm faking it!" log message but then the app crashes with
|
|
@zeebok How about now? |
zeebok
approved these changes
Jun 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.