Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PartitionBlock: GObject #813

Merged
merged 6 commits into from
Sep 30, 2024
Merged

PartitionBlock: GObject #813

merged 6 commits into from
Sep 30, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Sep 24, 2024 •
edited
Loading

Moves the menu up to partitionview so we're not passing it through two objects

@danirabbit danirabbit changed the title DRY DiskBar construction, PartitionBlock: GObject PartitionBlock: GObject Sep 25, 2024
@danirabbit danirabbit marked this pull request as ready for review September 25, 2024 16:55
@danirabbit danirabbit requested a review from a team September 25, 2024 20:57
ryonakano
ryonakano reviewed Sep 28, 2024
View reviewed changes
Copy link
Contributor

@ryonakano ryonakano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe the following signal no longer used?

src/Widgets/PartitionBlock.vala:9:    public signal void decrypted (InstallerDaemon.LuksCredentials credential);

@danirabbit danirabbit merged commit eae9af3 into main Sep 30, 2024
5 checks passed
@danirabbit danirabbit deleted the danirabbit/dry-diskbar-construction branch September 30, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryonakano ryonakano ryonakano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @ryonakano