Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow donating a message to elementary #963

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

leolost2605
Copy link
Member

This would be very useful to investigate issues like #957 or #950 where normal forwarding doesn't work as that just takes the html and builds an entirely new message whereas this only modifies sender and recipient of the original message and sends it as is. For now it gets sent to a throwaway address of mine but it probably would be good to create an account (maybe even an elementary one?) that all contributors have access to (make credentials available in slack?) and change it to that before merging this.
Any feedback regarding design, phrasing or whether this might be problematic in a way would be very appreciated! :)

Below every message:
image

When the link is clicked:
Screenshot from 2023-09-14 18 31 24

Fixes #409

@leolost2605 leolost2605 requested a review from a team September 14, 2023 17:08
@marmeladapk
Copy link

Would it be possible to hide that in 3 dot menu for each message? If that line would be added to every message then it would be quite jarring.

TBH, something even better would be an ability to save a complete email into a file (outlook has that option).

@leolost2605
Copy link
Member Author

Would it be possible to hide that in 3 dot menu for each message? If that line would be added to every message then it would be quite jarring.

I agree that this might be annoying when added below every message. My issue with the three dot menu was that I didn't find a good short phrase that would describe what this does (e.g. Donate seemed a bit vague and confusing to me), any ideas?

TBH, something even better would be an ability to save a complete email into a file (outlook has that option).

That sure is possible if we want it and could be implemented additionally. Still I would prefer the way this PR works over having to download the source and then create an issue with that source because the latter just adds a lot more friction. Also with access to the account for donation messages maybe being somewhat limited to elementary contributors this would maybe preserve a little bit more privacy with not everyone being able to just read the messages and mail address.

@wout
Copy link

wout commented Sep 18, 2023

Love the idea!

(e.g. Donate seemed a bit vague and confusing to me), any ideas?

What about Send feedback... to bring it in line with the Feedback app?

@jlnr
Copy link
Member

jlnr commented Sep 18, 2023

TBH, something even better would be an ability to save a complete email into a file (outlook has that option).

macOS Mail supports message drag and drop as EML files, which can then be compressed and attached to GitHub issues. That also works to attach one message to another one within the mail app. I find that quite elegant, and it also makes it easier to audit the information I'm sending as EML is a plain-text format.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Donate an email for debugging
4 participants