Bubble: minor refactor #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeebok
reviewed
Jun 26, 2023
src/Bubble.vala
Outdated
| dismiss (); | ||
| }); | ||
| protected override bool leave_notify_event (Gdk.EventCrossing event) { | ||
| if (notification.priority < GLib.NotificationPriority.HIGH) { |
There was a problem hiding this comment.
Wasn't there a change recently with notifications because we treat high priority as a normal priority? I would think this is supposed to be less than urgent is that is the case.
There was a problem hiding this comment.
That's #189, i prefer to keep PRs the most self-contained possible, so that they can be reviewed and merged in any order.
|
@Marukesu can you resolve conflicts here please? |
Merged
Signed-off-by: Gustavo Marques <[email protected]>
Signed-off-by: Gustavo Marques <[email protected]>
DRY the content creation code by handling it in the setter for the notification property. Signed-off-by: Gustavo Marques <[email protected]>
Marukesu
force-pushed
the
maru/bubble-fix-replace-contents
branch
from
93d84b5 to
8cb9676
Compare
|
@danirabbit done. |
lenemter
approved these changes
Jun 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
remove the
replace()method andconstructblock in favor of construct the contents widget in one place. we also stop checking if the notification has no action for launching the application, instead we launch it whenever we don't have a default action.Fixes some cases of #195/#145.
Fixes: #170