Implement system updates

[leolost2605]

Featurewise this should be pretty much on par with what appcenter currently does. In my testing it was very reliable and quite fast since it only has to deal with packagekit and not appstream and/or flatpak.

It will send notifications about updates, restart required and update failed.

This goes towards addressing elementary/appcenter#2107. Since we need packagekit for ubuntudrivers anyways I started with this (and because I know packagekit and don't know ubuntu drivers or the distro agnostic driver management mentioned there. The only thing I could find in this direction was an old solus project 🤷)

[danirabbit]

Another piece of information I'd like here is last refresh time so we can display a string like we do here: https://github.com/elementary/appcenter/blob/b33d12c6485644512d7e3d52264397562a89f605/src/Views/AppListUpdateView.vala#L256C1-L260C23

[Conan-Kudo]

This looks mostly good, I assume this triggers PackageKit's offline-updates mechanism?

[leolost2605]

This looks mostly good, I assume this triggers PackageKit's offline-updates mechanism?

Yup that's right

[leolost2605]

Another piece of information I'd like here is last refresh time so we can display a string like we do here: https://github.com/elementary/appcenter/blob/b33d12c6485644512d7e3d52264397562a89f605/src/Views/AppListUpdateView.vala#L256C1-L260C23

Done however it's not used to delay checks for updates but I also don't think that's necessary or is it?

[danirabbit]

@leolost2605 I think AppCenter checks when the timer runs if it's been more than 24 hours since the last refresh time and skips if it hasn't so that you don't get it checking multiple times if you've already checked manually. I'm not sure how much it really costs for us to check again 🤷‍♀️

[leolost2605]

@danirabbit yeah I think performance wise it's pretty much negligible if you've got more than 100 kB download.
However I've seen some issues about too frequent update notifications so I wonder whether we should address that?

[danirabbit]

Just a few things mainly about notifications

[leolost2605]

Ok this uses systemd timers now. However when testing them with sudo systemctl start io.elementary.settings-daemon.check-for-system-updates.service they fail with this error message:

Failed to set bus address: $DBUS_SESSION_BUS_ADDRESS and $XDG_RUNTIME_DIR not defined (consider using --machine=<user>@.h>

Same with the already existing firmware timers or rather their service files

I did some googling and found it works when installed in the user unit dir and then started with --user but the current version still has system unit dir because I'm pretty sure I missed something obvious since I have pretty much no experience with systemd units.

Btw maybe totally unrelated but both timers also don't get autostarted for me...?

Anybody any ideas here?

[danirabbit]

@Marukesu or @tintou maybe?

[danirabbit]

@leolost2605 perhaps we should revert back to the previous timer method and then we can try to switch to systemd timers in a follow up branch so that we're not blocking this feature while we wait for someone with more expertise

[leolost2605]

Done!

[danirabbit]

I'm really happy with this feature! I think we can iterate/expand/etc after merging but this all works as expected. Great work! 🚀