Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Buttons: Rewrite #1278

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Buttons: Rewrite #1278

wants to merge 1 commit into from

Conversation

danirabbit
Copy link
Member

@danirabbit danirabbit commented Jan 17, 2024 •
edited
Loading

Try to rewrite with fewer overrides and selectors that are easier to follow

  • Circular image buttons are now flat by default
  • All image buttons are now circular by default (might be a mistake)
  • Popover image buttons might need a default background?
  • Image buttons in OSDs have a duplicate background we probably don't want

BEFORE

Screenshot from 2024-01-17 14 54 57
Screenshot from 2024-01-17 14 54 51
Screenshot from 2024-01-17 14 54 44
Screenshot from 2024-01-17 14 54 39

AFTER

Screenshot from 2024-01-17 14 53 44
Screenshot from 2024-01-17 14 53 35
Screenshot from 2024-01-17 14 53 31
Screenshot from 2024-01-17 14 53 27

@wpkelso wpkelso mentioned this pull request Nov 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@danirabbit