Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Settings widgets #1279

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Remove Settings widgets #1279

merged 3 commits into from
Apr 1, 2024

Conversation

danirabbit
Copy link
Member

@danirabbit
Copy link
Member Author

I actually think I might wanna hold on this. I think I'll change the widget css name in Settings to SettingsPage so that it doesn't clash with SimpleSettingsPage and then we can remove these styles once all the panes are migrated over

@danirabbit
Copy link
Member Author

All the panes have been migrated and nothing should be using these styles in GTK 4 anyways

@danirabbit danirabbit merged commit 345d92e into main Apr 1, 2024
3 checks passed
@danirabbit danirabbit deleted the danirabbit/rm-settingswidgets branch April 1, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
OS 8
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@danirabbit @zeebok