Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Library: Add settings page and sidebar #281

Merged
merged 4 commits into from
Jan 24, 2024
Merged

Conversation

danirabbit
Copy link
Member

Fixes #265

Part 1.1 of my evil plan to flatten Settings. Instead of having to add window controls and a navigation button individually to every plugin, we can do it in these widgets and cover the majority of plugins

@leolost2605
Copy link
Member

Is this ready? :)

@danirabbit
Copy link
Member Author

@leolost2605 yes! This just imports the existing widgets with no changes to make review easier

Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok was just asking because no review was requested 😅

LGTM, I can confirm the widgets can be used by plugs :)

@danirabbit danirabbit enabled auto-merge (squash) January 24, 2024 21:51
@danirabbit danirabbit merged commit 62403e8 into main Jan 24, 2024
4 checks passed
@danirabbit danirabbit deleted the danirabbit/lib-settingspage branch January 24, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move SettingsPage, SettingsSidebar into Switchboard
2 participants