Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CategoryView: use a Adw.ToolbarView #305

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

danirabbit
Copy link
Member

Saves us some view specific CSS and can be re-used in plugins where we have a stack switcher in the header

Screenshot from 2024-03-21 14 42 43

@danirabbit danirabbit requested a review from a team March 21, 2024 21:49
Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally liked the flat design better 🤔

Or what is kind of the direction you want to go here?

@danirabbit
Copy link
Member Author

@leolost2605 Yeah I'm not tied to that. Reverted! Mainly I want to fix these: elementary/switchboard-plug-keyboard#509

Copy link
Member

@leolost2605 leolost2605 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@danirabbit danirabbit merged commit 38801a9 into main Mar 22, 2024
2 of 4 checks passed
@danirabbit danirabbit deleted the danirabbit/categoryview-adwtoolbarview branch March 22, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants