Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding timeout to clear the search field #327

Merged
merged 3 commits into from
Oct 22, 2024
Merged

Adding timeout to clear the search field #327

merged 3 commits into from
Oct 22, 2024

Conversation

alainm23
Copy link
Contributor

Fixed #182

@alainm23 alainm23 requested a review from a team October 22, 2024 16:22
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also happens if you use the clear button. So maybe what would be better would be to add the timeout in the search changed handler before we call invalidate_filter?

@danirabbit
Copy link
Member

Also don't forget to update metainfo with the bugfix line please :)

@alainm23 alainm23 requested a review from danirabbit October 22, 2024 20:31
@alainm23
Copy link
Contributor Author

I found a better way to fix it.

Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Clean! love not having to rely on a timeout too. Good job

@danirabbit danirabbit merged commit 161154a into main Oct 22, 2024
4 checks passed
@danirabbit danirabbit deleted the fix/182 branch October 22, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search returns alphabetically sorted list after clicking on a search result
2 participants