Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Highlight search string matches in bold #328

Merged
merged 6 commits into from
Oct 23, 2024
Merged

Highlight search string matches in bold #328

merged 6 commits into from
Oct 23, 2024

Conversation

alainm23
Copy link
Contributor

@alainm23 alainm23 commented Oct 22, 2024 •
edited
Loading

Fixed #149

image

@alainm23 alainm23 requested a review from a team October 22, 2024 17:09
danirabbit
danirabbit reviewed Oct 22, 2024
View reviewed changes
src/SearchView.vala Outdated Show resolved Hide resolved
@alainm23
Copy link
Contributor Author

alainm23 commented Oct 22, 2024 •
edited
Loading

I further optimized the code, it works in all the scenarios.

@alainm23 alainm23 requested a review from danirabbit October 22, 2024 22:16
danirabbit
danirabbit approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@danirabbit danirabbit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, way more concise haha. Great job!

@danirabbit danirabbit merged commit 418e508 into main Oct 23, 2024
4 checks passed
@danirabbit danirabbit deleted the feat/149 branch October 23, 2024 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danirabbit danirabbit danirabbit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
OS 9
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Highlight search string matches in bold
2 participants
@alainm23 @danirabbit