Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Internal: Header/Footer templates-api [TMZ-276] #151

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

nicoladj77
Copy link
Contributor

@nicoladj77 nicoladj77 requested a review from nuritsha January 6, 2025 11:05
Copy link
Collaborator

@nuritsha nuritsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments and questions

modules/template-parts/documents/document-base.php Outdated Show resolved Hide resolved
modules/theme/components/theme-overrides.php Outdated Show resolved Hide resolved
Comment on lines 57 to 61
add_action( 'elementor/editor/localize_settings', function ( $data ) {
$data['close_modal_redirect_hello_plus'] = admin_url( 'admin.php?page=hello-biz' );

return $data;
} );
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be a filter or an action?

modules/template-parts/module.php Outdated Show resolved Hide resolved
modules/template-parts/documents/document-base.php Outdated Show resolved Hide resolved
@nuritsha nuritsha changed the title Internal: Refactor approach for redirecting on close modal [TMZ-276] Internal: Header/Footer templates-api [TMZ-276] Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants