Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional ServiceProvider.SigningCertificate #26

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Commits on Apr 5, 2019

  1. Made ServiceProvider.SigningCertificate Optional

    The HttpRedirectBindingBuilder.SigningKey setter allows for null values.
    
                    // Check if the key is of a supported type. [SAMLBind] sect. 3.4.4.1 specifies this.
                    if (!(value is RSACryptoServiceProvider || value is DSA || value == null))
                    {
                        throw new ArgumentException("Signing key must be an instance of either RSACryptoServiceProvider or DSA.");
                    }
    
    This expression which is used to assign to that property fails if the ServiceProvider does not have a SigningCertificate.
    
                        SigningKey = config.ServiceProvider.SigningCertificate.PrivateKey,
    
    Added the Elvis operator to implement this.
    
                        SigningKey = config.ServiceProvider.SigningCertificate?.PrivateKey,
    samunro authored Apr 5, 2019
    Configuration menu
    Copy the full SHA
    a444961 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d6afeb5 View commit details
    Browse the repository at this point in the history

Commits on Apr 9, 2019

  1. Default to RedirectAfterLogin in SamlAuthenticationHandler.ApplyRespo…

    …nseChallengeAsync
    
    The current default is currentUri which does not seem like the best choice if a value for RedirectAfterLogin is available.
    
    I was expecting the browser to be redirected to RedirectAfterLogin post authentication but I actually saw an endless loop of authentications because it was redirecting to currentUri.
    samunro authored Apr 9, 2019
    Configuration menu
    Copy the full SHA
    fffb8da View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2020

  1. Configuration menu
    Copy the full SHA
    e9b9601 View commit details
    Browse the repository at this point in the history

Commits on Aug 31, 2021

  1. There were errors with Azure AD. The metadata included RoleDescriptor…

    …s of type SecurityTokenServiceType and ApplicationServiceType which were not expected. There was a workaround which involved removing those but that also meant that the signature had to be removed. I added types which allows the metadata to be deserialized - even if there is no special handling for them.
    
    The certificates in the SAML response were being passed in a way that the existing code did not expect. They are now parsed successfully.
    samunro committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    befc1ac View commit details
    Browse the repository at this point in the history
  2. There were problems with checking the signature on an assertion becau…

    …se it was a hash of the whole document that was being used instead of one based on just the assertion.
    samunro committed Aug 31, 2021
    Configuration menu
    Copy the full SHA
    fedab88 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    c13ec71 View commit details
    Browse the repository at this point in the history