-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Optional ServiceProvider.SigningCertificate #26
base: master
Are you sure you want to change the base?
Commits on Apr 5, 2019
-
Made ServiceProvider.SigningCertificate Optional
The HttpRedirectBindingBuilder.SigningKey setter allows for null values. // Check if the key is of a supported type. [SAMLBind] sect. 3.4.4.1 specifies this. if (!(value is RSACryptoServiceProvider || value is DSA || value == null)) { throw new ArgumentException("Signing key must be an instance of either RSACryptoServiceProvider or DSA."); } This expression which is used to assign to that property fails if the ServiceProvider does not have a SigningCertificate. SigningKey = config.ServiceProvider.SigningCertificate.PrivateKey, Added the Elvis operator to implement this. SigningKey = config.ServiceProvider.SigningCertificate?.PrivateKey,
Configuration menu - View commit details
-
Copy full SHA for a444961 - Browse repository at this point
Copy the full SHA a444961View commit details -
Configuration menu - View commit details
-
Copy full SHA for d6afeb5 - Browse repository at this point
Copy the full SHA d6afeb5View commit details
Commits on Apr 9, 2019
-
Default to RedirectAfterLogin in SamlAuthenticationHandler.ApplyRespo…
…nseChallengeAsync The current default is currentUri which does not seem like the best choice if a value for RedirectAfterLogin is available. I was expecting the browser to be redirected to RedirectAfterLogin post authentication but I actually saw an endless loop of authentications because it was redirecting to currentUri.
Configuration menu - View commit details
-
Copy full SHA for fffb8da - Browse repository at this point
Copy the full SHA fffb8daView commit details
Commits on Nov 27, 2020
-
Configuration menu - View commit details
-
Copy full SHA for e9b9601 - Browse repository at this point
Copy the full SHA e9b9601View commit details
Commits on Aug 31, 2021
-
There were errors with Azure AD. The metadata included RoleDescriptor…
…s of type SecurityTokenServiceType and ApplicationServiceType which were not expected. There was a workaround which involved removing those but that also meant that the signature had to be removed. I added types which allows the metadata to be deserialized - even if there is no special handling for them. The certificates in the SAML response were being passed in a way that the existing code did not expect. They are now parsed successfully.
Configuration menu - View commit details
-
Copy full SHA for befc1ac - Browse repository at this point
Copy the full SHA befc1acView commit details -
There were problems with checking the signature on an assertion becau…
…se it was a hash of the whole document that was being used instead of one based on just the assertion.
Configuration menu - View commit details
-
Copy full SHA for fedab88 - Browse repository at this point
Copy the full SHA fedab88View commit details -
Configuration menu - View commit details
-
Copy full SHA for c13ec71 - Browse repository at this point
Copy the full SHA c13ec71View commit details