Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix CPU usage on windows #27

Merged
merged 5 commits into from
Sep 6, 2024
Merged

Fix CPU usage on windows #27

merged 5 commits into from
Sep 6, 2024

Conversation

kuramochia
Copy link
Contributor

Fix CPU usage on Windows ( #24 ).

@kuramochia
Copy link
Contributor Author

Hello @ChekTek , Can you check and review this?

Elgato-AStory
Elgato-AStory approved these changes Aug 23, 2024
View reviewed changes
Copy link
Contributor

@Elgato-AStory Elgato-AStory left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Since we can't sync refresh timers with Task Manager, it's not perfectly in sync so some people might still complain, but it's clear that this performance counter is much closer to what task manager is using, if not the same.

@kuramochia
Copy link
Contributor Author

Thank you for your review.
Admittedly, the timing isn't perfect, but I think you'll get the same CPU usage as Task Manager.

@Elgato-AStory Elgato-AStory merged commit 863eff2 into elgatosf:master Sep 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elgato-AStory Elgato-AStory Elgato-AStory approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kuramochia @Elgato-AStory