This repository has been archived by the owner on Jun 6, 2021. It is now read-only.
Patch 2 #18
Open
Patch 2 #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 22, 2015 18:43
1 - at line 216 you regex is completly wrong (so is completly randoming result)
2 - You should never never change the user data in line 222 you do so weird things and i found myslef have a date like this
-- expected ==> 12/06/2015
-- after youre class modification 06/12/2015
so remove the 222 line or fix your code.
thanks.
fix the regex and for now removing the date format
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix date regex and remove formating date at generateCell method