Add a connection listener that emits telemetry events #311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v0idpwn
force-pushed
the
telemetry-from-listener
branch
from
eeb93f5 to
9a1783b
Compare
josevalim
reviewed
Jun 25, 2024
josevalim
reviewed
Jun 25, 2024
|
I added two documentation sections. I'm afraid it's a bit hidden in the documentation, but the I also considered starting one of these on DBConnection supervision tree, with a name, to make it easier to configure (no need to start a process), but I guess it's not worth it, since most people won't use it. |
josevalim
reviewed
Jul 1, 2024
josevalim
approved these changes
Jul 1, 2024
|
Almost merged it as |
|
@josevalim I would love if this could be released soon, it would help us at @coingaming to improve an alarm. |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative to #310. Would have to write documentation, etc.