Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

draft of data workflow diagram task #1528

Merged
merged 8 commits into from
Dec 6, 2024

Conversation

vildead
Copy link
Contributor

@vildead vildead commented Sep 13, 2024

No description provided.

@vildead
Copy link
Contributor Author

vildead commented Sep 13, 2024

I still plan to find nice example of such a diagram (maybe even two - one simple and one complex)

Also, I am not sure the page fits to RDMKit or it would be better to have it in FAIRCookbook (or both to some extend).

Copy link
Collaborator

@marikapop marikapop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well written page, Vilem (thumb up).
Does Hanna have diagram in her DMP? It is EU project, DMP could be public and being consortium vise might not contain confidential info.

pages/your_tasks/data_workflow_diagram.md Outdated Show resolved Hide resolved
pages/your_tasks/data_workflow_diagram.md Outdated Show resolved Hide resolved
pages/your_tasks/data_workflow_diagram.md Outdated Show resolved Hide resolved
pages/your_tasks/data_workflow_diagram.md Outdated Show resolved Hide resolved
pages/your_tasks/data_workflow_diagram.md Outdated Show resolved Hide resolved
pages/your_tasks/data_workflow_diagram.md Outdated Show resolved Hide resolved
pages/your_tasks/data_workflow_diagram.md Outdated Show resolved Hide resolved
pages/your_tasks/data_workflow_diagram.md Outdated Show resolved Hide resolved
pages/your_tasks/data_workflow_diagram.md Outdated Show resolved Hide resolved
pages/your_tasks/data_workflow_diagram.md Show resolved Hide resolved
@bedroesb bedroesb linked an issue Sep 16, 2024 that may be closed by this pull request
@Nazeeefa
Copy link
Collaborator

Nazeeefa commented Dec 5, 2024

Thanks @vildead 🤩 I think the title should be "Creating a data workflow" so that it suggests how to visualise your project data in a workflow (diagram). Current title "data workflow diagram" suggests, to me at least, that the page will include specific diagram that I am being suggested/recommended to use for my datasets.

pages/your_tasks/data_workflow_diagram.md Outdated Show resolved Hide resolved
pages/your_tasks/data_workflow_diagram.md Outdated Show resolved Hide resolved
pages/your_tasks/data_workflow_diagram.md Outdated Show resolved Hide resolved
pages/your_tasks/data_workflow_diagram.md Outdated Show resolved Hide resolved
pages/your_tasks/data_workflow_diagram.md Outdated Show resolved Hide resolved
pages/your_tasks/data_workflow_diagram.md Outdated Show resolved Hide resolved
pages/your_tasks/data_workflow_diagram.md Outdated Show resolved Hide resolved
@vildead
Copy link
Contributor Author

vildead commented Dec 6, 2024

@Nazeeefa thanks for the suggestions! I have implemented the changes.

@vildead vildead requested a review from Nazeeefa December 6, 2024 08:44
@@ -4,7 +4,7 @@ page_id: plan
description: Introduction to data management planning.
contributors: [Siiri Fuchs, Korbinian Bösl, Minna Ahokas, Federico Bianchini, Flora D'Anna]
related_pages:
your_tasks: [compliance, costs, dmp, data_security, dm_coordination, machine_actionability]
your_tasks: [compliance, costs, dmp, data_security, dm_coordination, machine_actionability, data_workflow_diagram]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vildead can you also kindly update name here?

_data/news.yml Outdated
@@ -194,3 +194,7 @@
date: 2024-10-24
linked_pr: 1526
description: The page is enriched with additional links and a bibliography. [Discover the page here](human_pathogen_genomics).
- name: "New page: Data workflow diagram"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bedroesb can you kindly update page name here after "News page"? The new name is "Creating Data Workflow"

@Nazeeefa Nazeeefa merged commit dcf8813 into elixir-europe:master Dec 6, 2024
4 checks passed
@jennytdtran
Copy link

Very nice! I have added some suggestions. Adding example(s) of data flow diagram would make it even better!

faircookbook:
---

## How should you draw a data workflow diagram?

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
## How should you draw a data workflow diagram?
## How to draw a data workflow diagram?


### Considerations

* A simple diagram can significantly improve clarity and communication and it's essential to first consider the complexity of the workflow. For complex project with multiple steps, data sources, or stakeholders, a diagram is invaluable for identifying steps, dependencies, potential issues and ensuring everyone has a shared understanding.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* A simple diagram can significantly improve clarity and communication and it's essential to first consider the complexity of the workflow. For complex project with multiple steps, data sources, or stakeholders, a diagram is invaluable for identifying steps, dependencies, potential issues and ensuring everyone has a shared understanding.
* A simple diagram can significantly improve clarity and communication and it's essential first to consider the complexity of the workflow. For complex project with multiple steps, data sources, or stakeholders, a diagram is invaluable for identifying steps, dependencies, potential issues and ensuring everyone has a shared understanding.


* A simple diagram can significantly improve clarity and communication and it's essential to first consider the complexity of the workflow. For complex project with multiple steps, data sources, or stakeholders, a diagram is invaluable for identifying steps, dependencies, potential issues and ensuring everyone has a shared understanding.
* The more complex the workflow, the more time and effort it will take to create and update the diagram. It is important to plan carefully and ensure that the time invested in diagram creation and updates is manageable and that your contribution is clearly recognized.
* A diagram may include sensitive or confidential information or reveal critical details that could be exploited by attackers, such as system vulnerabilities or data access points. Therefore, be cautious about sharing information publicly. Ensure that appropriate security measures are in place and such information is properly protected to prevent security breaches.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be good to provide a link to examples of these security measures

@bedroesb
Copy link
Member

bedroesb commented Dec 6, 2024

thank you @jennytdtran I think this pull request got a bit pre maturely merged. I agree with your suggestions, and will try to bring them still in.

@vildead I now just nottice that creating a data workflow gives a wrong impression to the page. We do not describe how to make a workflow, but how to make a diagram. Can we change the title/page to creating a workflow diagram?

@bedroesb
Copy link
Member

bedroesb commented Dec 6, 2024

Thanks @vildead 🤩 I think the title should be "Creating a data workflow" so that it suggests how to visualise your project data in a workflow (diagram). Current title "data workflow diagram" suggests, to me at least, that the page will include specific diagram that I am being suggested/recommended to use for my datasets.

@Nazeeefa I do not agree with this I am afraid. Making a workflow gives the impression this is data analysis related, while in reality it is how to make a diagram. @elixir-europe/rdmkit-editors other opinions?

@Nazeeefa
Copy link
Collaborator

Nazeeefa commented Dec 6, 2024

@bedroesb I think we are thinking along the same lines - my first feedback was about the initial title which was missing the keyword creating. I agree with you that "diagram" is also a keyword. Sorry I was focused more on making sure to give readers a right impression that we are talking about how to create not that specific material is provided for download/reuse.

@diana-pilvar
Copy link
Collaborator

I'm looking at the published page and wondering why the specific solution steps are not in the cookbook as a recipe.

@vildead
Copy link
Contributor Author

vildead commented Dec 17, 2024

It could certainly go there! I feel the cookbook page will need more detailed description with graphical examples of each step.

@vildead
Copy link
Contributor Author

vildead commented Dec 17, 2024

I have created an issue in Faircookbook: FAIRplus/the-fair-cookbook#637

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New page - How to draw a research data flow diagram
6 participants