Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Code.Fragment.surround_context/2 handles &123 as :capture_arg #13847

Merged
merged 1 commit into from
Oct 16, 2024
Merged

Code.Fragment.surround_context/2 handles &123 as :capture_arg #13847

merged 1 commit into from
Oct 16, 2024

Conversation

sabiwara
Copy link
Contributor

Close #13818

There is a precedent for the name capture_arg is used here, so I thought it would be clear, but happy to rename it.

@josevalim
Copy link
Member

My only question is if we want to go with an abbreviation. Although we already use abbreviations on local_or_var, so it is fine by me. Let's see if anyone else has objections and we can ship it. /cc @whatyouhide @ericmj @lukaszsamson

@lukaszsamson
Copy link
Contributor

No objections to abbreviations if they are documented

@sabiwara sabiwara merged commit f99c856 into elixir-lang:main Oct 16, 2024
9 checks passed
@sabiwara sabiwara deleted the fragment-capture branch October 16, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@josevalim josevalim josevalim approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Code.Fragment.surround_context miss-categorises atom keys and &1 capture variables
3 participants
@sabiwara @josevalim @lukaszsamson