Update README: Test Sandbox File Location #765
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A warning is issued for use of `get_env/2` used outside of a module. The warning suggests using `compile_env/3` instead. This change updates the documentation to conform to this suggestion and remove the warning, resulting in a cleaner and more modern setup for `wallaby`. Resolves [elixir-wallaby#761](elixir-wallaby#761)
The test environment is unable to read an `.ex` file located in the `config/` dir by default for Phoenix apps as of v1.7 This change makes a small edit to the README to suggest the `sandbox.ex` file be placed in the `test/support` dir.
|
Im going to close this and reopen with a branch that lacks merge commits, I sync'd with upstream poorly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test environment is unable to read an
.exfilelocated in the
config/dir by default for Phoenixapps as of v1.7
This change makes a small edit to the README to suggest
the
sandbox.exfile be placed in thetest/supportdir.