Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure codecov #13

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Configure codecov #13

merged 2 commits into from
Nov 6, 2023

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Nov 6, 2023

  • disabled github notifications that something is not covered by tests
  • we don't need to wait for other checks to run codecov
  • changed the layout of codecov comment so we see more info. Behavior default means that the comment is updated when new commits appear
  • disabled coverage threshold

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #13 (d32a1aa) into master (1aeef5b) will increase coverage by 0.64%.
Report is 1 commits behind head on master.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master      #13      +/-   ##
==========================================
+ Coverage   74.12%   74.77%   +0.64%     
==========================================
  Files           9        9              
  Lines         344      333      -11     
==========================================
- Hits          255      249       -6     
+ Misses         89       84       -5     
Files Coverage Δ
lib/ex_webrtc/session_description.ex 0.00% <ø> (ø)
lib/ex_webrtc/peer_connection.ex 74.23% <66.66%> (-0.18%) ⬇️
lib/ex_webrtc/peer_connection/configuration.ex 66.66% <66.66%> (+16.66%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d86ac87...d32a1aa. Read the comment docs.

@mickel8 mickel8 requested a review from LVala November 6, 2023 15:25
Copy link
Member

@LVala LVala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was about to do similar changes, but it seems that this time I won the "be very annoyed and do nothing about it" contest.

@mickel8 mickel8 merged commit e3f734e into master Nov 6, 2023
4 checks passed
@mickel8 mickel8 deleted the codecov branch November 6, 2023 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants