Update Fly.io instructions #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgfn
approved these changes
Oct 8, 2024
Comment on lines
+51
to
+54
| - RUN apt-get update -y && apt-get install -y build-essential git \ | ||
| - && apt-get clean && rm -f /var/lib/apt/lists/*_* | ||
| + RUN apt-get update -y && apt-get install -y build-essential git pkg-config libssl-dev \ | ||
| + && apt-get clean && rm -f /var/lib/apt/lists/*_* |
There was a problem hiding this comment.
We could mention that it may be necessary to add libsrtp2-dev as well -- notably when building on an arm64 machine (or targeting arm64 Linux in general, seeing as ex_libsrtp doesn't provide a prebuilt package in that case)
guides/deploying/fly.md
Outdated
|
|
||
| * configure a STUN server both on the client and server side | ||
| * use a custom Fly.io IP filter on the server side | ||
|
|
||
| In theory, configuring a STUN server just on one side should be enough but we recommend doing it on both sides. | ||
| * slightly modify auto-generated Dockerfile |
There was a problem hiding this comment.
Suggested change
| * slightly modify auto-generated Dockerfile | |
| * slightly modify the auto-generated Dockerfile |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #169 +/- ##
==========================================
+ Coverage 87.82% 87.87% +0.04%
==========================================
Files 45 45
Lines 2358 2358
==========================================
+ Hits 2071 2072 +1
+ Misses 287 286 -1 see 1 file with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.