Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix rtcp for no track #170

Merged
merged 2 commits into from
Oct 10, 2024
Merged

Fix rtcp for no track #170

merged 2 commits into from
Oct 10, 2024

Conversation

roznawsk
Copy link
Contributor

@roznawsk roznawsk commented Oct 8, 2024

It may happen, that after removing_track, we still receive PLI for that track, which has been already removed from the transceiver.

Below are logs from the fishjam media server

pli-fail-logs.txt

@roznawsk roznawsk requested a review from mickel8 October 8, 2024 08:29
Copy link
Member

@mickel8 mickel8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably do the same for all other handle_rtcp_packet clauses 🤔

@roznawsk
Copy link
Contributor Author

roznawsk commented Oct 9, 2024

I added it in the other case, where we handle rtcp on an outbound track. Let me know if you think the issue can appear also on the inbound tracks.

@roznawsk roznawsk requested a review from mickel8 October 9, 2024 11:19
Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 87.75%. Comparing base (363fae9) to head (d030474).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
lib/ex_webrtc/peer_connection.ex 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #170      +/-   ##
==========================================
- Coverage   87.82%   87.75%   -0.08%     
==========================================
  Files          45       45              
  Lines        2358     2360       +2     
==========================================
  Hits         2071     2071              
- Misses        287      289       +2     
Files with missing lines Coverage Δ
lib/ex_webrtc/peer_connection.ex 85.65% <0.00%> (-0.26%) ⬇️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 363fae9...d030474. Read the comment docs.

@mickel8 mickel8 merged commit 261122a into master Oct 10, 2024
3 checks passed
@mickel8 mickel8 deleted the fix-nil-track branch October 10, 2024 11:47
@mickel8
Copy link
Member

mickel8 commented Oct 10, 2024

Thanks!

@mickel8
Copy link
Member

mickel8 commented Oct 10, 2024

Released as 0.6.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants