Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for sending data #21

Merged
merged 9 commits into from
Nov 28, 2023
Merged

Allow for sending data #21

merged 9 commits into from
Nov 28, 2023

Conversation

LVala
Copy link
Member

@LVala LVala commented Nov 24, 2023

Additionally, modify the examples to create a media loop (browser -> Elixir PeerConnection -> browser).

@LVala LVala self-assigned this Nov 24, 2023
Copy link

codecov bot commented Nov 24, 2023

Codecov Report

Merging #21 (0d0a0f7) into master (16043e7) will decrease coverage by 4.27%.
The diff coverage is 47.88%.

❗ Current head 0d0a0f7 differs from pull request most recent head e8cef4e. Consider uploading reports for the commit e8cef4e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #21      +/-   ##
==========================================
- Coverage   84.05%   79.78%   -4.27%     
==========================================
  Files          10       10              
  Lines         483      475       -8     
==========================================
- Hits          406      379      -27     
- Misses         77       96      +19     
Files Coverage Δ
lib/ex_webrtc/media_stream_track.ex 100.00% <100.00%> (ø)
lib/ex_webrtc/rtp_transceiver.ex 92.30% <100.00%> (-0.29%) ⬇️
lib/ex_webrtc/dtls_transport.ex 80.00% <42.10%> (-5.37%) ⬇️
lib/ex_webrtc/peer_connection.ex 72.41% <48.00%> (-7.38%) ⬇️

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 16043e7...e8cef4e. Read the comment docs.

@LVala LVala requested a review from mickel8 November 27, 2023 11:18
@LVala LVala marked this pull request as ready for review November 27, 2023 11:18
lib/ex_webrtc/dtls_transport.ex Outdated Show resolved Hide resolved
lib/ex_webrtc/dtls_transport.ex Outdated Show resolved Hide resolved
lib/ex_webrtc/peer_connection.ex Outdated Show resolved Hide resolved
lib/ex_webrtc/peer_connection.ex Show resolved Hide resolved
@LVala LVala merged commit 363500a into master Nov 28, 2023
2 checks passed
@LVala LVala deleted the simple-loopback branch November 28, 2023 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants