Generate SDP answer from RTPTransceivers #3

mickel8 · 2023-10-20T16:29:37Z

This PR doesn't include SSRC in the SDP answer but we still get media from the browser. I will try to handle SSRC values in subsequent PRs.

codecov · 2023-10-20T16:30:06Z

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Files	Coverage Δ
lib/ex_webrtc/rtp_codec_parameters.ex	`100.00% <100.00%> (ø)`
lib/ex_webrtc/peer_connection.ex	`38.38% <0.00%> (+2.74%)`	⬆️
lib/ex_webrtc/rtp_transceiver.ex	`62.16% <57.57%> (-37.84%)`	⬇️

📢 Thoughts on this report? Let us know!.

Base automatically changed from rtp-transceiver to master October 23, 2023 08:15

mickel8 force-pushed the sdp-answer branch 6 times, most recently from 8a1992c to 31c1a79 Compare October 23, 2023 10:38

mickel8 changed the title ~~Parse RTPCodecParameters~~ Generate SDP answer from RTPTransceivers Oct 23, 2023

mickel8 force-pushed the sdp-answer branch from 31c1a79 to 9b40cf9 Compare October 23, 2023 10:40

mickel8 marked this pull request as ready for review October 23, 2023 10:41

Generate answer from RTPTransceivers

04d3b90

mickel8 force-pushed the sdp-answer branch from 9b40cf9 to 04d3b90 Compare October 23, 2023 10:42

mickel8 requested a review from LVala October 23, 2023 10:45

LVala approved these changes Oct 24, 2023

View reviewed changes

mickel8 merged commit fdcc06f into master Oct 24, 2023
2 checks passed

mickel8 deleted the sdp-answer branch October 24, 2023 07:01