Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure ICE credentials #5

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Ensure ICE credentials #5

merged 1 commit into from
Oct 25, 2023

Conversation

mickel8
Copy link
Member

@mickel8 mickel8 commented Oct 24, 2023 •
edited
Loading

We assume that:

  • if there are no session level ice credentials, every mline has to have the same ufrag and pwd
  • if there are session level ice credentials, every mline might have ufrag or pwd. When mline has ufrag or pwd it must be the same as session level ufrag or pwd

@codecov
Copy link

codecov bot commented Oct 24, 2023 •
edited
Loading

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Files Coverage Δ
lib/ex_webrtc/peer_connection.ex 38.00% <100.00%> (-1.22%) ⬇️
lib/ex_webrtc/sdp_utils.ex 87.27% <90.90%> (+5.45%) ⬆️

📢 Thoughts on this report? Let us know!.

@mickel8 mickel8 force-pushed the ensure-ice-cred branch 2 times, most recently from 0af46c1 to 886b599 Compare October 24, 2023 20:12
@mickel8 mickel8 marked this pull request as ready for review October 25, 2023 07:20
@mickel8 mickel8 requested a review from LVala October 25, 2023 07:24
@mickel8 mickel8 merged commit fd81504 into master Oct 25, 2023
4 checks passed
@mickel8 mickel8 deleted the ensure-ice-cred branch October 25, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LVala LVala LVala approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mickel8 @LVala