Add initial implementation of craete_offer, apply_local_description and add_transceiver
#6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
mickel8
approved these changes
Oct 26, 2023
lib/ex_webrtc/rtp_transceiver.ex
Outdated
| {:fingerprint, Keyword.fetch!(config, :fingerprint)}, | ||
| {:setup, Keyword.fetch!(config, :setup)}, | ||
| :rtcp_mux | ||
| ] ++ if(Keyword.get(config, :rtcp, false), do: [{"rtcp", "9 IN IP4 0.0.0.0"}], else: []) |
There was a problem hiding this comment.
Nitpick but if that's not a big problem I would put this as first attribute.
This way we will have something like this
m=audio 9 UDP/TLS/RTP/SAVPF 111 63 9 0 8 13 110 126
c=IN IP4 0.0.0.0
a=rtcp:9 IN IP4 0.0.0.0
so all address related lines next to each other
lib/ex_webrtc/peer_connection.ex
Outdated
| else | ||
| for mline <- state.current_remote_desc.media, | ||
| {:mid, mid} <- ExSDP.Media.get_attribute(mline, :mid), | ||
| {mid, _} <- Integer.parse(mid) do |
There was a problem hiding this comment.
why tho? String.to_integer might rise and I wanted to avoid that.
lib/ex_webrtc/peer_connection.ex
Outdated
Comment on lines
474
to
475
| max_mid = Enum.max(crd_mids ++ tsc_mids, &>=/2, fn -> -1 end) + 1 | ||
| max(state.next_mid, max_mid + 1) |
There was a problem hiding this comment.
Looks like one +1 is not needed
| }; | ||
|
|
||
| const mode = "passive" |
There was a problem hiding this comment.
Very nice example modification 👍
lib/ex_webrtc/peer_connection.ex
Outdated
| @@ -35,7 +41,10 @@ defmodule ExWebRTC.PeerConnection do | |||
| :dtls_buffered_packets, | |||
| dtls_finished: false, | |||
| transceivers: [], | |||
| signaling_state: :stable | |||
| signaling_state: :stable, | |||
| next_mid: 0, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.