-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adding rtcp processing example #76
adding rtcp processing example #76
Conversation
b895d50
to
090f233
Compare
Hi @themusicman, thanks for the contribution! A couple of notes:
I would favor adding a clause for RTCP in our defp handle_webrtc_msg({:rtcp, _packets}, state) do
# do something with RTCP packets
{:ok, state}
end This way:
|
090f233
to
b48e05f
Compare
@mickel8 Fair points. I updated the PR. Is there anything that you want help with in regards to the project? Maybe |
Thanks for the PR @themusicman! i have deleted the comment as we are going to talk about RTCP in our guides section (in hex docs) at some point.
That's something @LVala is already working on! Other things I have in my mind but are not planned for 0.2 (i.e. neither @LVala nor me are going to work on them)
and many more, I will update the list later this evening 😉 |
@mickel8 I was thinking about suggesting datachannels too. I will look into that some and come up with a plan for implementation and present it to you. What do you think about that? |
@themusicman Sounds great! |
@themusicman I've created a new section in our Roadmap where I put things that can be addressed: #28 |
Wanted to contribute an example like the one in the Pion project here: https://github.com/pion/webrtc/tree/master/examples/rtcp-processing