Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: postgres-adapter - remove nonsensical schema check #1377

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

ryanleecode
Copy link
Contributor

Relates to:

Closes: #1376

Risks

Background

What does this PR do?

What kind of change is this?

Documentation changes needed?

Testing

Where should a reviewer start?

Detailed testing steps

Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

monilpat
monilpat previously approved these changes Dec 23, 2024
Copy link
Collaborator

@monilpat monilpat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolve merge conflict then good to go

@odilitime
Copy link
Collaborator

a lot of queries on each start up but probably fast ones

@ryanleecode
Copy link
Contributor Author

a lot of queries on each start up but probably fast ones

Yah, but i dont think its an issue because were not running on a serverless runtime. eliza has to run on a box. Also idk if eliza is already doing this but all startup IO operations should be parallelized to minimize total startup time.

@odilitime odilitime changed the title fix(postgres-adapter): remove nonsensical schema check fix: postgres-adapter - remove nonsensical schema check Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants