fix: resolve TODO to make model more dynamic and generic #1408
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
harperaa
changed the title
|
Feedback is welcome on my first PR. Let me know how I can improve, going forward. |
|
LGTM, nice work! Can you please change the upstream for this to the 'develop' branch? Can merge it in there. :) |
Hi, if that was for me, I am sorry, don't know how to do that... can you share commands? |
|
sorry, tried to change it on my end and it closed the PR... is there a way for me to do that? |
|
Sorry, new here... is there a way for me to change the branch name on my end, without it automatically closing the PR? |
|
figured it out...learning. |
|
nice work! I actually don't know the process by heart, either; got
sidetracked before looking it up. glad you figured it out yourself, best
way to learn. looking forward to the next one! :)
…On Mon, Dec 23, 2024 at 5:15 PM Allen Harper ***@***.***> wrote:
figured it out...learning.
—
Reply to this email directly, view it on GitHub
<#1408 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/A2PEDCQXUCM5TFFG5W3NPUD2HCYT5AVCNFSM6AAAAABUDQSJY2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRQGUYDENZYGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
odilitime
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to:
#1223
Risks
Background
What does this PR do?
Removes hard wired model name in summarizeAction and instead uses the selected model, with fallback to gpt-4o-mini.
What kind of change is this?
Improvements (misc. changes to existing features)
Documentation changes needed?
My changes do not require a change to the project documentation.
Testing
pnpm build passed, no linting issues.
Where should a reviewer start?
Detailed testing steps