Updates and a couple of fixes for add servo support to magnetic probe #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ot fire until after stowing has occured, should just continue to stow the probe as it has just finished homing - Add pre deploy and stow steps to allow for position of nozzle to be in a safe place after ABL etc - Include sanity check for deactivate servos to include mounted probe servo
…com/ellensp/Marlin into ellensp/add-servo-support-to-magnetic-probe
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Requirements
When moving to stow a probe it does not use the z after homing position before continuing, this leaves the z probe pressed against the bed, if stowing, it should just continue to try and stow the probe.
When checking the configuration and using deactivate_servos_after_move the sanity check needs to now take into account the new config setting.
After completing a sequence which makes use of the probe, such as homing, ABL etc, it should move to a safe position before deploying or stowing.
Benefits
Configurations
Add two configuraitons one for pre deploy of the probe and one for pre stow of the probe, this is to allow the nozzle to be moved to a save position before deploying or stowing and stops crashes into the moved servo arm.
Related Issues
No other issues in this PR